Jump to content
×
×
  • Create New...

Application for script writer I rank


Recommended Posts

Hello fellas!

I'd like to apply for script writer to get my agility script published as a free script, so people can use it. It's made for mobile with mobile in mind, a bit iffy on desktop, but works. I've botted 3 accounts to full graceful and botted in total now over 2000 falador laps (see github pictures).

I don't mind it being open source (for possible newcomers or such?) and I don't claim it's written well, it was part of a learning experience and so far is my most tested and polished script. Any feedback is appreciated, anyways.

Rooftops supported: Draynor -> Al Kharid -> Varrock -> Canifis -> Falador

Using this script from 10 agility you should expect to receive full graceful at around 700-800 falador laps and 63-65 agility.

 

Github: https://github.com/Paberimees/PaperRooftops

Link to post
Share on other sites

Posted (edited)

Looks ok.

I haven't tested it but maybe it would improve performance if you test for inViewport when moving towards something - https://bit.ly/3fok4KB.

Have you tried using reachable for finding marks? It may simplify some checks (if it works).

Also, I think you should probably add basic healing. You can literally just filter anything edible( actions contain "Eat" and/or "Drink") -  https://bit.ly/2QPFab3.

Otherwise, nice work.  No bans from agi script is impressive 😄

Edited by Toma
Link to post
Share on other sites

21 hours ago, Toma said:

Looks ok.

I haven't tested it but maybe it would improve performance if you test for inViewport when moving towards something - https://bit.ly/3fok4KB.

Have you tried using reachable for finding marks? It may simplify some checks (if it works).

Also, I think you should probably add basic healing. You can literally just filter anything edible( actions contain "Eat" and/or "Drink") -  https://bit.ly/2QPFab3.

Otherwise, nice work.  No bans from agi script is impressive 😄

Hey, thanks Toma for taking the time to review and congrats on your bachelors 🙂 

So, playing with desktop actually seems to have dished out bans sadly after 42 or so agility, specifically usually on the varrock course. Other than that using this on mobile again soon for (possibly) 4 graceful sets, so will see about that, but doubt that using this on mobile will dish out any bans. Will report back with findings.

I'll try and do some refractoring and improvements after I'm done with my exams and have some free time, experiment with inViewport and try to make it feel more fluid overall, implement Seers and healing, possibly make the GUI nicer.

  • Like 1
Link to post
Share on other sites

A lot of repeated code in your courses, all the overrided functions can be put into your Course class as well as the variables.

https://github.com/Paberimees/PaperRooftops/blob/master/src/paperrooftops/utility/courses/CanifisRooftop.java#L90

Can also reduce this function to a single line

public Obstacle getCurrentObstacle(Locatable x) {
        return trackList.stream().filter((obs) -> obs.getStartArea().containsOrIntersects(x)).findFirst().orElse(null);
}

 

 

You can use a JComboBox for selecting the course instead of using a switch statement to select course

 

Make sure you're on Java language level 8+ for lambdas, helps condense code like this into a single line

https://github.com/Paberimees/PaperRooftops/blob/master/src/paperrooftops/tasks/PickUpMarkOfGrace.java#L78

 

 

 

Link to post
Share on other sites

  • Moderators

While there are some suggestions for improvement as mentioned above, the script shows a strong foundation and a good understanding of the API with little in terms of anecdotal or example documentation.

With that, welcome to Script Writer 1 rank; congrats.

@const_ will follow up with your private repo separately.

Link to post
Share on other sites

  • Dan locked this topic
Guest
This topic is now closed to further replies.
 Share