Just some notes from the quick look at I had.
The following could be replaced with exp gained calculation(From starting) or using an inventory listener to see essence entering inventory
if (Skill.Mining.experience() > lastXPCount) {
Variables.get().essenceGained++;
System.out.println("Essence gained: " + Variables.get().essenceGained);
lastXPCount = Skill.Mining.experience();
lastActivityTime = System.currentTimeMillis();
}
Good to see this this. Some minor improvements
if ((UtilityLogic.timeFromMark(lastActivityTime)) >= 120000) {
System.out.println("No experience gained for over 2 minutes, failsafe activated. Shutting script down.");
onStop();
}
ScriptManager.INSTANCE.stop(); should be called instead of OnStop() as the intent for that is when it is already stopping so you shouldn't need to call it again.
Should call "return" after this as otherwise it will execute tasks still.
BankLogic
Withdraw always returns false even if successfull?
bankisOpen name is desceptive, it should be openBank
Some considerations
Using the Paint API - https://docs.powbot.org/#/Basic_Fundamentals/PaintBuilderAPI
Why do tasks executing specific logic need a reference to the main for status? It's not something the task should have to be concerned about
Interacting with inventory items does not need to check the tab is open, the API handles that.
.png.a1f44fafdaaad5ef3b0ea934a0135bb9.png)
